Skip to content

Conversation

bpkroth
Copy link
Collaborator

@bpkroth bpkroth commented Dec 7, 2023

Separates a conversion to Java 21 from #398 and also handles errors encountered in #369.

@bpkroth bpkroth changed the title WIP: Java 21 upgrade and enable compiler warnings Upgrade to Java 21 Dec 8, 2023
@bpkroth bpkroth marked this pull request as ready for review December 8, 2023 15:45
@bpkroth bpkroth added bug Something isn't working and removed enhancement New feature or request in-progress This PR is in progress. labels Dec 8, 2023
@bpkroth
Copy link
Collaborator Author

bpkroth commented Dec 8, 2023

@apavlo staging this as a smaller change, but there's a few other related ones.
Main concern here is that it is potentially a breaking change for folks using just the jar release, so we should probably also tag a new release commit once this is merged.
This change also incorporates a new version tag in the relevant files to match that.
Let me know if you have any other thoughts.

@bpkroth bpkroth requested a review from apavlo December 8, 2023 15:49
@bpkroth bpkroth mentioned this pull request Dec 8, 2023
@bpkroth
Copy link
Collaborator Author

bpkroth commented Dec 13, 2023

@apavlo staging this as a smaller change, but there's a few other related ones. Main concern here is that it is potentially a breaking change for folks using just the jar release, so we should probably also tag a new release commit once this is merged. This change also incorporates a new version tag in the relevant files to match that. Let me know if you have any other thoughts.

Discussed offline. Gonna merge this now and tag a new release. Thanks!

@bpkroth bpkroth merged commit b4b3668 into cmu-db:main Dec 13, 2023
@bpkroth bpkroth deleted the java-21 branch December 13, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetInterfaces test in TestClassUtil.java appears to be checking interfaces of Java builtins?
1 participant