-
Notifications
You must be signed in to change notification settings - Fork 37
Image refresh for fedora-rawhide-boot #8341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image refresh for fedora-rawhide-boot #8341
Conversation
|
image-refresh fedora-rawhide-boot done: https://github.com/cockpit-project/bots/commits/image-refresh-fedora-rawhide-boot-20251012-224209 |
2288688 to
af03530
Compare
|
@KKoukiou sorry to ping you twice but here TestStorageReclaimSpace.testReclaimSpaceOptional failed 3 times on the same error. Did something change here too and tests need to be updated? I see that tests are trying to work with |
af03530 to
13d438d
Compare
|
rebased to make sure I look into the new test failures. |
|
This is not a regression of this PR, this looks like an uncoverered incomplete cleanup: When test/check-storage-reclaim TestStorageReclaimSpace.testReclaimExt4onLUKS runs before TestStorageReclaimSpace.testReclaimSpaceOptional the latter fails. Please don't merge, I dont know why this does not happen on master, we need to debug. |
Can reproduce this with: So it is something new in the image as the old one succeeded, the partitioning view in the terminal looks correct but the UI is out of date. |
|
I am looking into it. It really seems that our cleanup of the former /dev/vda1 LUKS partition does not work anymore in the new image. Maybe caused by update of blivet: packages diff: The Traceback from the log seems to be caused by unexpected detection of LUKS parttition: In the previous test WDYT? @vojtechtrefny? |
|
I may be blaming blivet too fast, the failing call comes from anaconda: |
|
Anaconda is doing storage rescan in the new test before wiping the old disks. With the new blivet it seems to fail because of this change: |
|
Blivet with fix has been built for rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=2851500 |
|
Spotted the package in the compose yesterday, so lets refresh. |
|
image-refresh fedora-rawhide-boot done: https://github.com/cockpit-project/bots/commits/image-refresh-fedora-rawhide-boot-20251031-080540 |
3dcd862 to
33e58ac
Compare
martinpitt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Image refresh for fedora-rawhide-boot