-
Notifications
You must be signed in to change notification settings - Fork 37
doc: AsciiDoctor for Ubuntu/Debian #8393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
image-refresh debian-trixie done: https://github.com/cockpit-project/bots/commits/image-refresh-debian-trixie-20251028-150425 |
|
This script is shared with Ubuntu, maybe I should have said so. Do all Ubuntu's have asciidoctor? Secondly this should go into the build chroot, see bedcfc8 |
|
Sorry I triggered the tests before submitting my comment. |
8297003 to
c1ca030
Compare
c1ca030 to
6314d44
Compare
Yeah from what I can see all of them should have
Ack, moved it there now |
images/scripts/debian.setup
Outdated
| # TEMP: until asciidoc migration is into cockpit.git. | ||
| asciidoctor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does that even work? I suppose that was meant as an additional argument to apt-get, but it's on its own line now, aso called as a command. Supposedly that only works because that script isn't set -e?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh shoot.. I'm tired. Yeah I meant to use apt-get
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
6314d44 to
710836d
Compare
|
I don't think this was properly refreshed? Asciidoctor would not be in the buildchroot, just checked: Please re-refresh. |
710836d to
53c7e1a
Compare
Adds `asciidoctor` for Ubuntu 22/24 and Debian Trixie as required by the asciidoc PR. Related-to: cockpit-project/cockpit#21515 Signed-off-by: Freya Gustavsson <[email protected]>
53c7e1a to
6d6c621
Compare
|
image-refresh debian-trixie done: https://github.com/cockpit-project/bots/commits/image-refresh-debian-trixie-20251031-135107 |
Weird, likely fixed then undid it somehow. @jelly PTAL now 🙏 |
Adds
asciidoctorfor Ubuntu 22/24 and Debian Trixie as required by theasciidoc PR.
Related-to: cockpit-project/cockpit#21515
Related-to: https://issues.redhat.com/browse/COCKPIT-1339
Signed-off-by: Freya Gustavsson [email protected]