workflows: Run urls-check in GitHub workflows

[marusak]

Also fixing bug why no po-refresh and npm-update were triggered.

Tried it on my own fork.

• Successful run of urls-check - Validate all URLs marusak/cockpit#33
• Successful run on npm-update - package.json: Update @patternfly/patternfly package dependency marusak/cockpit#34

[martinpitt]

Thanks! One fix necessary, then we can move this. I think we should also change urls-check to not create an issue at all if the check succeeds, that's just useless noise. It's enough if it files an issue on a broken check? (That's follow-up material, of course)

[martinpitt]

That has the same problem, though?

[marusak]

yeah, I fix it with the other commit. Should I do this the right way in the first commit?

[martinpitt]

Ah, yes please, less confusing.

[marusak]

done

[martinpitt]

This doesn't commit anything, so we don't strictly need a git config here.

[marusak]

true, I'll drop it.

[marusak]

done

[marusak]

I think we should also change urls-check to not create an issue at all if the check succeeds, that's just useless noise. It's enough if it files an issue on a broken check?

urls-check is smart in this matter. It works like this:

• It looks for the last issue for urls-check
• If it is opened, it does nothing (waits until we fix it)
• If it is closed and the last update was more than n-days ago, it runs the check
• If the check succeeds it just comments into that closed issue that all is fine (just so we can see it ran and it bumps up the last modification [see previous point])
• If it fails, it opens a new issue (see the second point)
• (special case) If there is no opened nor closed issue and the check succeeded then create a new issue, comment all went fine and close it. This happens when we run this for the first time in a repository. And this is what you saw.

[martinpitt]

Yay, thanks!