-
-
Notifications
You must be signed in to change notification settings - Fork 751
"Fix issue Auto_pause_when_tab_change #3022" #3025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@wbalbo pls review it sir |
Where is the rest? The toggle should be in messages.json and is not in your code, how can we enable/disable the feature? You agree to use a toggle in the previous PR and ignore it in this code. Again, try to not use AI for everything and understand the code, look at the PR that I mentioned before and you will understand how to implement these things. Also, @ImprovedTube, I am not sure if the init.js is the best place to put this code. Should not be a specific function to be called once the toggle is on, like the others? Thanks. |
@wbalbo sir Just to clarify I didn’t create a new toggle.
@wbalbo sir Just to clarify I didn’t create a new toggle. |
Ah okay, sorry then, my bad. I didn't know that we had this option. Some options are still new to me. Good, then, makes sense to me. But I can't merge anything. |
@ImprovedTube pls review it |
hi @Shashank4516 looks good! can be merged if it helps
just started that for some (mentioned here again in italic #3023 (comment) ) |
This pull request introduces a new feature to
js&css/web-accessible/init.js
that enhances user experience by adding functionality to handle tab visibility changes.Feature addition:
js&css/web-accessible/init.js
: Added an event listener for thevisibilitychange
event to invokeImprovedTube.playerAutopauseWhenSwitchingTabs
when switching tabs, ensuring the player automatically pauses if the function is defined.