Add unit tests #8
Conversation
krsriq
left a comment
krsriq
left a comment
There was a problem hiding this comment.
This is coming together quite nicely! Just a couple of cleanup tasks.
Depending on how far you want to go with this, there are a couple of obvious refactoring opportunities here
- the
$from/$toparsing ingetRecordingscould be moved to a separate method (code repetition, andgetRecordingsis kind of long and does a lot imo) - move
getAccessTokento a separate class (kind of smelly that this can't be tested..)
krsriq
force-pushed
the
switch-to-s2s-oauth-apps-tests
branch
2 times, most recently
from
65e9173 to
11ee4bd
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
krsriq
force-pushed
the
switch-to-s2s-oauth-apps-tests
branch
from
11ee4bd to
1092669
Compare
krsriq
force-pushed
the
switch-to-s2s-oauth-apps-tests
branch
from
1092669 to
69a074c
Compare
|
Review again. I moved the |
krsriq
left a comment
krsriq
left a comment
There was a problem hiding this comment.
Getting there - the main service class looks much cleaner now.
I've added a (now failing) test to make you aware of an issue that would not have become apparent without that test - see comments!
krsriq
left a comment
krsriq
left a comment
There was a problem hiding this comment.
Found a couple more bugs.
After these are fixed I think we're done here!
| { | ||
| $response = $this->client->get($uri); | ||
| if ($response->getStatusCode() !== 200) { | ||
| throw new ZoomApiException(sprintf('Could not fetch Zoom paginated data for data key "%s", returned status "%s"', $paginatedDataKey, $response->getStatusCode()), 1695239983421); |
There was a problem hiding this comment.
This line is still suspiciously not covered by tests - and has a bug (guess you can find it on your own ;) ).
There was a problem hiding this comment.
Sollte jetzt gefixt sein, was meinst du? ;-)
Ich habe jetzt auch noch PHPStan hinzugefügt und Codesniffer
gradinarufelix
force-pushed
the
switch-to-s2s-oauth-apps-tests
branch
from
b0a1310 to
9fbf997
Compare
composer installcomposer test