Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Conversation

@hliasa
Copy link

@hliasa hliasa commented Jul 13, 2023

This fix allows HTTP source repository type URL in the form of "https://example.com/updates/subfolder". Before the fix the update URL would become (e.g. for app-v1.2.3.zip) "https://example.com/app-v1.2.3.zip" when it should be "https://example.com/updates/subfolder/app-v1.2.3.zip".

In case of a URL without a path, an empty string is returned:

URL: https://example.com/updates/v2
Scheme: string(5) "https"
Host: string(11) "example.com"
Path: string(11) "/updates/v2"
baseUrl: https://example.com/updates/v2

URL: https://example.com
Scheme: string(5) "https"
Host: string(11) "example.com"
Path: string(0) ""
baseUrl: https://example.com

This fix allows HTTP source repository type URL in the form of "https://example.com/updates/subfolder".
Before the fix the update URL would become (e.g. for app-v1.2.3.zip) "https://example.com/app-v1.2.3.zip" when it should be "https://example.com/updates/subfolder/app-v1.2.3.zip".
@codedge codedge closed this Sep 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants