Skip to content

Conversation

mjomble
Copy link

@mjomble mjomble commented Sep 18, 2025

Description
Fixed bug introduced in #9581 and described in this comment

  • isEmpty() was checking the opposite
  • The checks did not work if $this->data was null

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@mjomble
Copy link
Author

mjomble commented Sep 18, 2025

I'll look into adding a unit test for the Logs controller

@mjomble mjomble marked this pull request as draft September 18, 2025 09:22
@mjomble mjomble marked this pull request as ready for review September 18, 2025 10:42
Copy link

mergeable bot commented Sep 18, 2025

Hi there, mjomble! 👋

Thank you for sending this PR!

We expect the following in all Pull Requests (PRs).

Important

We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works.

If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work
on the framework than you do. Please make it as painless for your contributions to be included as possible.

See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md

Sincerely, the mergeable bot 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant