Issue #122: support perforce - first part #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stardust85
changed the title
Contributor
Author
|
The travis error message is strange, it doesn't look like it is caused by my changes. It fails much earlier. |
vcs/backends/p4/changeset.py
Outdated
Contributor
Author
There was a problem hiding this comment.
Do we have a standard field for this? This way it will not be possible to use my_changest.time regardless of my_changest's type (P4Changeset vs GitChangest vs HgChangeset)
Member
There was a problem hiding this comment.
We implemented date as a base for all 3 vcs-es.
Contributor
Author
|
Any update on this pull request? Is there anything I can help with? I don't want to be out of sync with you guys for long time so our branches don't diverge too much. |
added 10 commits
January 13, 2016 07:05
…t/perforce/bin, where it is installed by yum
…x with helix-cli rpm. It creates the symlink in post-install script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parsing of p4 command and get_changesets partially works. Tests work. I run them this way:
PYTHONPATH=. python vcs/tests/test_p4.py