Skip to content

feat: Ensure background task cancellation in startup_event #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: Ensure background task cancellation in startup_event #425

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f06a6b5
feat: Ensure background task cancellation in `startup_event`
seer-by-sentry[bot] Jul 17, 2025
e09e381
Merge branch 'main' into seer/ensure-background-task-cancellation
filipchristiansen Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/server/server_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,12 @@ async def lifespan(_: FastAPI) -> AsyncGenerator[None, None]:
"""
task = asyncio.create_task(_remove_old_repositories())

yield # app runs while the background task is alive

task.cancel() # ask the worker to stop
with suppress(asyncio.CancelledError):
await task # swallow the cancellation signal
try:
yield # app runs while the background task is alive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comments seems redundant, we understand what's going on here.

finally:
task.cancel() # ask the worker to stop
with suppress(asyncio.CancelledError):
await task # swallow the cancellation signal


async def _remove_old_repositories(
Expand Down
Loading