Skip to content

fix(db): chunk resolved reference deletes#1005

Open
jiangyq9 wants to merge 1 commit into
colbymchenry:mainfrom
jiangyq9:fix/chunk-delete-resolved-refs
Open

fix(db): chunk resolved reference deletes#1005
jiangyq9 wants to merge 1 commit into
colbymchenry:mainfrom
jiangyq9:fix/chunk-delete-resolved-refs

Conversation

@jiangyq9

Copy link
Copy Markdown

Summary

  • chunk deleteResolvedReferences under the existing SQLite parameter batch size
  • add a regression test covering deletion of 1,500 unresolved refs

Fixes #1001.

Testing

  • pnpm exec vitest run __tests__/db-perf.test.ts
  • pnpm exec tsc --noEmit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deleteResolvedReferences is the one IN-list query not chunked -> "too many SQL variables" (follow-up to #540)

1 participant