Open
Conversation
ocrete
requested changes
Feb 9, 2026
There was a problem hiding this comment.
Pull request overview
Adds documentation for the Palm Detection model’s output tensors and registers the new tensor/tensor-group IDs in the central registry.
Changes:
- Introduces a new tensor doc describing
palm-detection-out-detectionslayout/encoding. - Introduces a new tensor-group doc describing
palm-detection-outoutputs and decoding logic. - Updates
tensor-id-register.mdto include the new tensor and tensor-group entries.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| tensors/palm-detection-out-detections.md | New documentation for Palm Detection detections tensor shape/encoding. |
| tensor-id-register.md | Registers the new Palm Detection tensor ID and tensor-group ID. |
| tensor-groups/palm-detection-out.md | New documentation for the Palm Detection output tensor-group and decoding/orientation notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+26
to
+33
| Scheme: (Score, Box_X, Box_Y, Box_Size, Keypoint0_X, Keypoint0_Y, Keypoint1_X, Keypoint1_Y) | ||
|
|
||
| The tensor contains 8 channels with the following layout per detection: | ||
|
|
||
| |Channel 0 | Channel 1 | Channel 2 | Channel 3 | Channel 4-5 | Channel 6-7 | | ||
| |--- |--- |--- |--- |--- |--- | | ||
| | Score | Box_X | Box_Y | Box_Size | Keypoint0 | Keypoint1 | | ||
| | pd_score | box_x | box_y | box_size | (x, y) | (x, y) | |
There was a problem hiding this comment.
Keypoint naming is inconsistent: the encoding scheme/table refer to “Keypoint1”, but the known alias and memory layout use kp2/keypoint2. Please align terminology (either rename kp2→kp1 everywhere or update the scheme/table to Keypoint2) so readers can decode channels 6–7 correctly.
- point palm detection model references at the Collabora onnx-models copy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PalmDetection output tensor