Repository navigation
Plone 6.2 support. Removed the Plone 4 themes profile and upgrade step - #4
Draft
chris-adam wants to merge 15 commits into
Draft
chris-adam wants to merge 15 commits into
chris-adam wants to merge 15 commits into
Conversation
Coverage Report for CI Build 37929923121Warning No base build found for commit Coverage: 100.0%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
chris-adam
marked this pull request as draft
October 8, 2026 06:59
chris-adam
force-pushed
the
plone61-chris-adam
branch
from
October 8, 2026 09:06
2a76514 to
8cb1507
Compare
Unit tests for the static files, bundles, theme bundles, uninstall and browser layer. Robot scenarios for tooltipster_helper as its callers use it (Plone 4 argument order), on a test-only view; they pass on Plone 4.3 (master) and fail on 6.1 until the helper regressions are fixed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Plone 6.0, 6.1 and 6.2 (test-6.2.cfg, Makefile, GHA matrix, coverage on 6.2). pkgutil-style namespace __init__ without namespace_packages: the pkg_resources declaration hides the native namespace eggs of 6.2. tooltipster_helper gets back the signature its callers use (view_content_selector moved into options) and calls the view on the context URL (body data-base-url, no <base> tag on Plone 6). Plone 4 themes profile and upgrade step removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chris-adam
force-pushed
the
plone61-chris-adam
branch
from
October 8, 2026 12:31
7cf2e9c to
3772d36
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the
plone61work (@chris-adam, @laulaz), rebased on master. Adds Plone 6.2 next to 6.0 and 6.1 (buildout, GHA matrix, pkgutil namespace that 6.2 needs), with unit tests and robot scenarios that pass on Plone 4.3 master and on 6.x.tooltipster_helpertakesdata_parameters3rd again, as every caller passes it (view_content_selectoris now an option), and calls the view on the context URL since Plone 6 has no<base>tag.themesprofile and the 1000→2000 upgrade step are removed (themes are default bundles on Plone 6).🤖 Generated with Claude Code