HKG: 2021 Kia Xceed PHEV #2708
HKG: 2021 Kia Xceed PHEV #2708
Conversation
Added KIA Xceed fingerprint to fingerprints.py
Added "Hybrid" to flags for kia ceed
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- include a route or your device' dongle ID if relevant
jyoung8607
changed the title
There was a problem hiding this comment.
Kia Ceed and XCeed are indeed very close: https://en.wikipedia.org/wiki/Kia_Ceed#XCeed
We need to rework how the HYBRID flag is set for HKG in general first, otherwise we'll end up having to add a bunch of unnecessary platform permutations.
| KIA_STINGER.specs, | ||
| ) | ||
| KIA_CEED = HyundaiPlatformConfig( | ||
| [HyundaiCarDocs("Kia Ceed 2019-21", car_parts=CarParts.common([CarHarness.hyundai_e]))], |
There was a problem hiding this comment.
Xceed will need an additional CarDocs entry at a minimum
| [HyundaiCarDocs("Kia Ceed 2019-21", car_parts=CarParts.common([CarHarness.hyundai_e]))], | ||
| CarSpecs(mass=1450, wheelbase=2.65, steerRatio=13.75, tireStiffnessFactor=0.5), | ||
| flags=HyundaiFlags.LEGACY, | ||
| flags=HyundaiFlags.LEGACY | HyundaiFlags.HYBRID, |
There was a problem hiding this comment.
We can't just add the HYBRID flag for all Ceed, that will break the non-hybrid cars. We could potentially add XCeed/Hybrid permutations, but ideally HYBRID should be auto-detected instead.
2 participants
I added kia xceed fingerprint to the kia ceed port, since they have the same CD platform. everything works as expected, also added the "hybrid" flag in values.py in order to get it to work.
Used Harness B for my car.
Validation