Skip to content

Safer get accel#37918

Merged
haraschax merged 2 commits intomasterfrom
safer_get_accel
Apr 26, 2026
Merged

Safer get accel#37918
haraschax merged 2 commits intomasterfrom
safer_get_accel

Conversation

@haraschax
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

Process replay diff report

Replays driving segments through this PR and compares the behavior to master.
Please review any changes carefully to ensure they are expected.

⚠️ 1 changed, 65 passed, 0 errors

Show changes

TOYOTA - regen218A4DCFAA1|2025-04-08--22-57-51--0 [plannerd]

  longitudinalPlan.aTarget (959 diffs)
    frame 0: 0.3723571300506592 -> 0.4887460470199585
    frame 1: 0.3468478322029114 -> 0.4830911159515381
    frame 2: 0.2743105888366699 -> 0.4165326952934265
    frame 3: 0.3703387975692749 -> 0.5036853551864624
    frame 4: 0.3001589775085449 -> 0.43995383381843567
    frame 5: 0.3139013648033142 -> 0.4524700343608856
    frame 6: 0.3477618098258972 -> 0.4831767678260803
    frame 7: 0.2882665991783142 -> 0.429179847240448
    frame 8: 0.4051167964935303 -> 0.5352203845977783
    frame 9: 0.39882996678352356 -> 0.5294433832168579
    (... 949 more)

@haraschax haraschax merged commit 545ad01 into master Apr 26, 2026
9 of 11 checks passed
@haraschax haraschax deleted the safer_get_accel branch April 26, 2026 16:48
@adeebshihadeh
Copy link
Copy Markdown
Contributor

Merged by mistake? Unit tests are failing

=========================== short test summary info ============================
SUBFAILED(title='steady state following a car at 20m/s, then lead decel to 0mph at 3m/s^2', e2e=True, force_decel=False) selfdrive/test/longitudinal_maneuvers/test_longitudinal.py::TestLongitudinalControl_1::test_maneuver - assert False
SUBFAILED(title='steady state following a car at 20m/s, then lead decel to 0mph at 3m/s^2', e2e=False, force_decel=False) selfdrive/test/longitudinal_maneuvers/test_longitudinal.py::TestLongitudinalControl_3::test_maneuver - assert False
FAILED selfdrive/test/longitudinal_maneuvers/test_longitudinal.py::TestLongitudinalControl_1::test_maneuver - contains 1 failed subtest
FAILED selfdrive/test/longitudinal_maneuvers/test_longitudinal.py::TestLongitudinalControl_3::test_maneuver - contains 1 failed subtest
============ 4 failed, 907 passed, 100 skipped, 1 xfailed in 27.12s ============

adeebshihadeh added a commit that referenced this pull request Apr 26, 2026
@adeebshihadeh
Copy link
Copy Markdown
Contributor

Reverted for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants