remove all spécial caracters from the sentence #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdavis-mozilla
suggested changes
Jun 14, 2019
Contributor
kdavis-mozilla
left a comment
kdavis-mozilla
left a comment
There was a problem hiding this comment.
You aren't considering all languages. For example you are removing valid characters in Greek.
Author
|
i will move the filter to the "fr" file |
kdavis-mozilla
suggested changes
Jul 2, 2019
| import re | ||
|
|
||
| # All special characters | ||
| FILTER_SYMBOLES_REG = re.compile( |
Contributor
There was a problem hiding this comment.
While FILTER_SYMBOLES_REG seems useful what might be better is a white list instead of a black list.
For example, the characters 男性 are not in your black list and would pass through un-altered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.