Change puremagic to python-magic #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue with python-magic is that it requires external dependency. Perhaps, let’s try magika? #13 |
You know, magika looks very promising. Let's try |
vrslev
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weeell, we have some problems. Puremagic is okay, until you start checking Microsoft extensions. I dunno, maybe the developer has some beef with MS or smth like this. As an example for .xls files, puremagic.from_string(file) returns ''. pure.magic_file(file) returns different mime_type, that we got used to. So, either we have to change mime_types and method to magic_file. Or swap completely towards python-magic. I prefer the second one. If you don't mind, let's stick with it