fix: resolve server from DB for SSH when client sends no ssh_key_path (fixes #466) #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fixes #466) - Add resolveServerForSSH() to load full server (including ssh_key_path) from DB when WebSocket server has id but key auth without valid ssh_key_path - Call resolver in handleMessage for all start flows (clone, backup, update, shell, script) so Shell and Update over SSH work with key auth - Extend ServerInfo typedef with auth_type, ssh_key_path for TypeScript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #466
When opening Shell or running Update over SSH with key auth, the client sends a server object built from script data (id, ip, user, auth_type, ssh_key, etc.) but without
ssh_key_path(server-side path). The SSH execution layer requiresssh_key_pathfor key auth, so it threw "SSH key file not found".This PR adds
resolveServerForSSH(server)in the WebSocket handler: when the incoming server hasidbut key auth without a validssh_key_path, we load the full server from the database and use it for the SSH call. All start flows (clone, backup, update, shell, script) now receive the resolved server.