Refactor the from_urdf function from RobotLibrary to Robot
#437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @classmethod | ||
| def from_urdf(cls, urdf_filename, srdf_filename=None, local_package_mesh_folder=None, client=None): | ||
| # type: (str, Optional[str], Optional[str], Optional[ClientInterface]) -> Robot |
There was a problem hiding this comment.
ClientInterface is not imported, is it? Does this work? Can you do a fully-qualified type here (ie. compas_fab.backends.interfaces.ClientInterface) to avoid importing only for the purpose of type checking?
Comment on lines
+144
to
+148
|
|
||
| if srdf_filename: | ||
| semantics = RobotSemantics.from_srdf_file(srdf_filename, model) | ||
| else: | ||
| semantics = None |
There was a problem hiding this comment.
Maybe this is a bit neater?
Suggested change
| if srdf_filename: | |
| semantics = RobotSemantics.from_srdf_file(srdf_filename, model) | |
| else: | |
| semantics = None | |
| semantics = None | |
| if srdf_filename: | |
| semantics = RobotSemantics.from_srdf_file(srdf_filename, model) |
|
Seems a really cool contribution. Any reason keeping you from merging @yck011522 ? |
I'm just slightly away from office these days. Will work on it soon. |
|
Happy holidays! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow other access to use that function.
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas_fab.robots.CollisionMesh.