add support for scene #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzalocasas
reviewed
Jul 3, 2025
Comment on lines
+61
to
+65
| transformation = ( | ||
| sceneobject.transformation | ||
| if sceneobject.transformation is not None | ||
| else Transformation() | ||
| ) |
There was a problem hiding this comment.
this is a bit convoluted syntax, why not plain:
Suggested change
| transformation = ( | |
| sceneobject.transformation | |
| if sceneobject.transformation is not None | |
| else Transformation() | |
| ) | |
| transformation = sceneobject.transformation | |
| if transformation is None: | |
| transformation = Transformation() |
| else Transformation() | ||
| ) | ||
|
|
||
| prim = prim_from_transformation(stage, "/" + "/".join(path), transformation) |
There was a problem hiding this comment.
does this path concat using / work on Windows also?
There was a problem hiding this comment.
should we not use pathlib or at least os.path for this?
| return prim | ||
|
|
||
|
|
||
| def prim_from_item(stage: Usd.Stage, item: Data, parent_path=[]) -> Usd.Prim: |
There was a problem hiding this comment.
don't use [] empty list as default arg value, this has nasty consequences.
There was a problem hiding this comment.
parent_path = parent_path or []
Comment on lines
+96
to
+101
| if isinstance(item, Box): | ||
| prim = prim_from_box(stage, "/" + "/".join(path), item) | ||
| elif isinstance(item, Sphere): | ||
| prim = prim_from_sphere(stage, "/" + "/".join(path), item) | ||
| elif isinstance(item, Mesh): | ||
| prim = prim_from_mesh(stage, "/" + "/".join(path), item) |
There was a problem hiding this comment.
Same question about whether these paths using the unix slash work on Windows.
There was a problem hiding this comment.
same comment about using pathlib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support to convert a compas scene to a usd stage.
plz see example added at
scripts/scene.py