Skip to content

Switch to our own builds of ancient Clang with assertions#1556

Closed
Endilll wants to merge 1 commit intocompiler-explorer:mainfrom
Endilll:ancient-clangs
Closed

Switch to our own builds of ancient Clang with assertions#1556
Endilll wants to merge 1 commit intocompiler-explorer:mainfrom
Endilll:ancient-clangs

Conversation

@Endilll
Copy link
Copy Markdown
Contributor

@Endilll Endilll commented Mar 27, 2025

An accompanying PR for compiler-explorer/clang-builder#84

@partouf
Copy link
Copy Markdown
Member

partouf commented Apr 10, 2025

As a test I have attempted to build assertions-2.6.0
This build appears to have failed:

https://github.com/compiler-explorer/infra/actions/runs/14382913649/job/40330991873#step:6:2408

The build itself reached 1200/1201, then it started to install and run "Clang regression tests" and failed with this error:

    File "/root/llvm-project/llvm/tools/clang/utils/test/MultiTestRunner.py", line 100
      print '%s: %s (%*d of %*d)' % (status, tr.path, 
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  SyntaxError: Missing parentheses in call to 'print'. Did you mean print(...)?
  ninja: build stopped: cannot make progress due to previous errors.

@Endilll
Copy link
Copy Markdown
Contributor Author

Endilll commented Apr 10, 2025

Sounds like python2 vs python3 issue

@Endilll
Copy link
Copy Markdown
Contributor Author

Endilll commented Apr 10, 2025

https://github.com/compiler-explorer/clang-builder/blob/36a0a5d0fff05ed6cd7d576184e88dbfe3cdb34f/Dockerfile#L31

RUN bash -c "if [[ ${image} == 16.04 || ${image} == 18.04 ]]; then apt install -y -q python; else apt install -y -q python-is-python3; fi"

We have a special line for python. Am I missing something about bash that prevents it from working as intended? CC @mattgodbolt

@partouf
Copy link
Copy Markdown
Member

partouf commented Apr 11, 2025

Ah! Yes, I had been wanting to ask that but forgot about it. How can we ask to build with an older image version @mattgodbolt ?

@mattgodbolt
Copy link
Copy Markdown
Member

The clang builder builds for multiple Ubuntu versions, and then we list them in infra's build somehow...I'll take a look in a bit!

mattgodbolt added a commit that referenced this pull request Apr 11, 2025
@mattgodbolt
Copy link
Copy Markdown
Member

Trying now with clang-16.04 builder and assertions-2.6.0 : https://github.com/compiler-explorer/infra/actions/runs/14404739603

mattgodbolt added a commit to compiler-explorer/clang-builder that referenced this pull request Apr 11, 2025
@mattgodbolt
Copy link
Copy Markdown
Member

retrying having fixed a naming thign :)

@mattgodbolt
Copy link
Copy Markdown
Member

https://github.com/compiler-explorer/infra/actions/runs/14404739603 succeeded! @Endilll / @partouf do we have a list of things to build? :)

@partouf
Copy link
Copy Markdown
Member

partouf commented Apr 11, 2025

To build:

  • assertions-2.6.0
  • assertions-2.7.0
  • assertions-2.8.0
  • assertions-2.9.0
  • assertions-3.0.0
  • assertions-3.1.0
  • assertions-3.2.0
  • assertions-3.3.0
  • assertions-3.4.0
  • assertions-3.5.0
  • assertions-3.6.0
  • assertions-3.7.0
  • assertions-3.8.0
  • assertions-3.9.0
  • assertions-4.0.0

@mattgodbolt
Copy link
Copy Markdown
Member

I'm starting building these now.

@mattgodbolt
Copy link
Copy Markdown
Member

mattgodbolt commented Apr 14, 2025

To force install:

  • assertions-2.6.0
  • assertions-2.7.0
  • assertions-2.8.0
  • assertions-2.9.0
  • assertions-3.0.0
  • assertions-3.1.0
  • assertions-3.2.0
  • assertions-3.3.0
  • assertions-3.4.0
  • assertions-3.5.0
  • assertions-3.6.0
  • assertions-3.7.0
  • assertions-3.8.0
  • assertions-3.9.0
  • assertions-4.0.0

To squash:

  • assertions-2.6.0
  • assertions-2.7.0
  • assertions-2.8.0
  • assertions-2.9.0
  • assertions-3.0.0
  • assertions-3.1.0
  • assertions-3.2.0
  • assertions-3.3.0
  • assertions-3.4.0
  • assertions-3.5.0
  • assertions-3.6.0
  • assertions-3.7.0
  • assertions-3.8.0
  • assertions-3.9.0
  • assertions-4.0.0

@mattgodbolt
Copy link
Copy Markdown
Member

I've piecemeal applied the changes in this PR (sorry @Endilll I should have merged this and then done that; I only needed one tiny change to your changes)

Will close as this is done; but continue to update with the status of squash/etc here. and I'll let you know when everything's rebooted etc

@mattgodbolt
Copy link
Copy Markdown
Member

one more to go...

@mattgodbolt
Copy link
Copy Markdown
Member

All built and squahsed. I'll be doing a roll out over the next few hours!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants