Stop generating libs= headers, rely on CE auto-discovery#2026
Merged
Conversation
CE PR #8552 makes the libs= property optional by auto-discovering library IDs from libs.<id>.* keys. This removes libs= generation and related merge logic from infra, since CE no longer needs it. Also fixes amazon_properties.py which would break after the CE PR removes libs= lines from upstream properties files -- the Windows fallback now checks for libs.* prefixed lines instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Makes it easy to test against other branches of compiler-explorer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to compiler-explorer/compiler-explorer#8552, which makes
libs=optional by auto-discovering library IDs fromlibs.<id>.*property keys.libs=headers in property output (C++, Rust, Fortran, Windows)libs=merge and update logic frommerge_propertiesandprocess_library_specific_propertiesamazon_properties.pyWindows fallback that would break once upstream removeslibs=lines -- now checks forlibs.*prefixed lines insteadTest plan
make static-checkspassesmake testpasses (550 tests, 0 failures)