-
Couldn't load subscription status.
- Fork 70
fix(driver): use flume instead of crossbeam #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
But why? |
|
No strong reasons.
|
|
Can you do a benchmark? |
|
I have done benchmarks. fn compio(c: &mut Criterion) {
let mut group = c.benchmark_group("asyncify");
group.throughput(Throughput::Elements(1));
group.bench_function("compio", |b: &mut Bencher| {
let runtime = compio::runtime::Runtime::new().unwrap();
b.to_async(&runtime)
.iter(|| async { runtime.spawn_blocking(|| black_box(())).await.unwrap() });
});
group.finish();
}However, it seems that |
On which machine and OS? Sadly but can't reproduce that on my own machine due to Desktop kernel settings and multicore nature. |
|
Windows on a laptop with 8 CPU cores (16 threads). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM





Also cleanup the features. We don't need the selector.