Increase coverage for BuildCommand, fix --no-html-output flag bug#1117
Merged
alcohol merged 1 commit intocomposer:mainfrom Mar 20, 2026
Merged
Increase coverage for BuildCommand, fix --no-html-output flag bug#1117alcohol merged 1 commit intocomposer:mainfrom
alcohol merged 1 commit intocomposer:mainfrom
Conversation
theimbender
force-pushed
the
build-command-coverage
branch
from
5640205 to
ad0f8d2
Compare
Member
|
Hmm, not sure if this qualifies as a BC.. the combined behaviour of the flag + config setting (or lack of) was rather weird it seems and I do believe your implementation makes more sense. But it does mean things might behave different in certain scenarios now. I think I can live with that though 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wanted to increase code coverage of
BuildCommand.phpto cover all the low-hanging fruit (i.e., anything that doesn't require mocking network requests or any kind of refactoring). I found that the--no-html-outputflag was not actually working at all, the logic was a little off. That's been refactored into a small private function, and I ran these changes with and without the flag to confirm that it's now working.