Conversation
…AccountCanProposeBelowThreshold`
3a53b5e to
b5ba34b
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
torreyatcitty
left a comment
There was a problem hiding this comment.
I think most of the changes were just formatting but I did have 1 question on where some storage variables ended up moving to.
Also, can you update the .prettierrc you used when formatting all of these files. There is definitely a line width since most of the changes were just from shorter lines I think? I would say let's check in the current on you got so future folks can all be consistent and things are a little easier to review.
| uint abstainVotes; | ||
| function queue(uint256) external; | ||
|
|
||
| /// @notice Flag marking whether the proposal has been canceled |
There was a problem hiding this comment.
Where did all of this storage stuff move to? Or were we just no longer user it?
There was a problem hiding this comment.
We aren't using it anymore
I believe these are the default settings for prettier? I didn't make any changes locally to |
This PR fixes CI testing and coverage. The coverage provider switches to codecov since codecov provides better support for multiple coverage files (hardhat and foundry).
Contracts that are no longer utilized by Compound DAO in production have been removed along with the associated tests--all contracts that are still used in production remain untouched.