Skip to content

Fix CI tests and coverage#23

Open
arr00 wants to merge 14 commits intomainfrom
chore/fix-ci
Open

Fix CI tests and coverage#23
arr00 wants to merge 14 commits intomainfrom
chore/fix-ci

Conversation

@arr00
Copy link
Copy Markdown
Collaborator

@arr00 arr00 commented Mar 23, 2026

This PR fixes CI testing and coverage. The coverage provider switches to codecov since codecov provides better support for multiple coverage files (hardhat and foundry).

Contracts that are no longer utilized by Compound DAO in production have been removed along with the associated tests--all contracts that are still used in production remain untouched.

@arr00 arr00 changed the title Fix tests Fix CI tests and coverage Mar 30, 2026
@arr00 arr00 force-pushed the chore/fix-ci branch 3 times, most recently from 3a53b5e to b5ba34b Compare March 31, 2026 05:20
@codecov-commenter
Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Copy Markdown
Collaborator

@torreyatcitty torreyatcitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most of the changes were just formatting but I did have 1 question on where some storage variables ended up moving to.

Also, can you update the .prettierrc you used when formatting all of these files. There is definitely a line width since most of the changes were just from shorter lines I think? I would say let's check in the current on you got so future folks can all be consistent and things are a little easier to review.

uint abstainVotes;
function queue(uint256) external;

/// @notice Flag marking whether the proposal has been canceled
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did all of this storage stuff move to? Or were we just no longer user it?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We aren't using it anymore

@arr00
Copy link
Copy Markdown
Collaborator Author

arr00 commented Apr 1, 2026

I think most of the changes were just formatting but I did have 1 question on where some storage variables ended up moving to.

Also, can you update the .prettierrc you used when formatting all of these files. There is definitely a line width since most of the changes were just from shorter lines I think? I would say let's check in the current on you got so future folks can all be consistent and things are a little easier to review.

I believe these are the default settings for prettier? I didn't make any changes locally to .perttierrc. The previous PR didn't follow the existing prettier config in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants