Open
Conversation
…ks to reduce the vendors chunk by not having solc installed in node_modules.
torreyatcitty
requested review from
alexandfox,
alysiawu,
banky and
hayesgm
as code owners
…oks to be deprecated so use a working version for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove solc from dependencies and update node version to 18. This looks to reduce the vendors chunk by not having solc installed in node_modules and the build generated locally looks way smaller.
However, the git action job won't generate a build because of the warning of
solcnot being able to be resolved in sleuth even though we don't use that method as it's only for supporting non-precompiled contracts.