Open
Conversation
This test looks to be failing with "MemoryLimitOOG," which seems like it's out of gas based on the memory limit, which seems about as close to the solution here as we're going to get. Since Forge isn't exactly the true EVM, there will always be minor discrepencies, but that's making direct reference to the memory limit.
fluffywaffles
approved these changes
Nov 22, 2023
kevincheng96
approved these changes
Nov 22, 2023
Collaborator
kevincheng96
left a comment
kevincheng96
left a comment
There was a problem hiding this comment.
Oh nice! Wonder why mstore works but mload doesn't. Shouldn't they both expand memory to the same offset?
cwang25
approved these changes
Nov 22, 2023
Contributor
Author
If I had to guess, it's getting compiled out by the yul optimizer? And it's probably a lot harder to optimize out a write than a read... |
Contributor
|
Trying to close some old PRs that's < #100 |
Collaborator
|
Think we still need to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test looks to be failing with "MemoryLimitOOG," which seems like it's out of gas based on the memory limit, which seems about as close to the solution here as we're going to get. Since Forge isn't exactly the true EVM, there will always be minor discrepencies, but that's making direct reference to the memory limit.
You can see the exact error code with: