Update CiviHR code to be CiviCRM 5.16 complient and convert CiviHR ca… #2987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…che group to be standard Civi::cache style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…che group to be standard Civi::cache style
Overview
This removes some uncessary caching storing as it doesn't appear to be doing. This also adds in a new cache.civihr service which is in the standard format as Civi::cache. Also it updates the navigation cache code to match standard for 5.16.
Before
Code using deprecated code functions
After
Code using standard cache
Technical Details
This creates a new service cache.HRCore_Info which is the standard way of defining Civi cache groups.