Improvement handling router login failures#1
Open
Skopik wants to merge 1 commit into
Open
Conversation
…l login failures. The me_logic.erl module reads the login result on the API and in case of a failure the me_connector.erl module retries to log in.
Owner
|
Good! |
Author
|
Yes, it will. I did not consider the wrong-password case. I admit that 2015-01-26 14:51 GMT+01:00 Valery notifications@github.com:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frequently I was experiencing failures to log in to the router (with correct credentials; I am not sure what the cause of the failures was), so I updated your code to handle such failures. I made the api_connect function wait for the result. Now, if the login fails (["!trap", "=message=cannot log in"] is received), it is repeated after one second - until the login succeeds. The code with this modification has been tested for over 2 months and works without problems.