[redis-plus-plus] Disable werror by default to avoid GCC-16 error - #30897
Open
uilianries wants to merge 1 commit into
Open
[redis-plus-plus] Disable werror by default to avoid GCC-16 error#30897uilianries wants to merge 1 commit into
uilianries wants to merge 1 commit into
Conversation
Signed-off-by: Uilian Ries <uilianr@jfrog.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: redis-plus-plus/1.3.15
Motivation
close #30798
Details
I can reproduce the reported scenario: When building redis-plus-plus/1.3.15 with GCC 16, I have the following error:
redis-plus-plus-1.3.15-linux-amd64-gcc16-release-static.log
After applying this patch, by removing multiple declarations of Werror from CMakeLists, I can build without errors:
redis-plus-plus-1.3.15-linux-amd64-gcc16-release-static-patched.log
Add a 👍 reaction to pull requests you find important to help the team prioritize, thanks!