Open
Conversation
This migration replaces the chrono crate with jiff for most datetime operations across the rattler codebase. Key changes include: - TimestampMs now wraps jiff::Timestamp instead of chrono::DateTime<Utc> - ExcludeNewer uses jiff::Timestamp and jiff::civil::Date for parsing - rattler_repodata_gateway Expiring struct uses jiff::Span for durations - rattler_package_streaming uses jiff for zip DateTime creation - py-rattler uses PyO3's jiff-02 feature for Python datetime interop - js-rattler converts to/from js_sys::Date via milliseconds Note: rattler_index still uses chrono for opendal compatibility since opendal's Metadata API requires chrono::DateTime<Utc>. Benefits of jiff: - More ergonomic API (Span parsing from strings like "1 week") - Better timezone handling - Native ISO 8601 format (T separator, Z suffix) - PyO3 integration via jiff-02 feature - WASM/JS support via js feature
Resolved merge conflicts to maintain jiff usage while incorporating main's new MinimumAgeConfig functionality: - Updated MinimumAgeConfig to use jiff::Timestamp instead of chrono - Replaced humantime::format_duration with jiff::Span::to_string() - Added min_age parameter to solve functions alongside exclude_newer
Change RepodataFileMetadata and cache types to use jiff::Timestamp instead of chrono::DateTime<Utc>. Chrono is now only used at the opendal boundary for conversion, as opendal's Metadata API still requires chrono types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from
chronotojiffwhich seems to be taking over.The current
opendalversion still depends onchrono