fix: accept documented log_hyperparameters decorator call forms - #3135
Open
BetterAndBetterII wants to merge 1 commit into
Open
fix: accept documented log_hyperparameters decorator call forms#3135BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
|
@BetterAndBetterII is attempting to deploy a commit to the Confident AI Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@deepeval.log_hyperparameters()and@deepeval.log_hyperparameters(model=..., prompt_template=...)raisedTypeErrorbecauselog_hyperparametersonly accepted a bare function argument. Both forms are used in the docs.Make the decorator accept optional call/kwargs while keeping the existing bare
@deepeval.log_hyperparametersform. Decorator kwargs are merged with the wrapped function’s returned dict (function values win on key clashes).Fixes #3134
Test plan
pytest tests/test_core/test_run/test_log_hyperparameters.py@log_hyperparameters()logs the returned dict@log_hyperparametersstill works