Skip to content

feat(card): add pushNotificationCardKycNotificationCtaText translations#5

Open
Brunonascdev wants to merge 1 commit intomainfrom
feat/mm-card-cta-texts
Open

feat(card): add pushNotificationCardKycNotificationCtaText translations#5
Brunonascdev wants to merge 1 commit intomainfrom
feat/mm-card-cta-texts

Conversation

@Brunonascdev
Copy link
Collaborator

@Brunonascdev Brunonascdev commented Mar 3, 2026

add pushNotificationCardKycNotificationCtaText translations


Note

Low Risk
Low risk: adds a new localized string key for a push-notification CTA across multiple locale JSON files, with no logic changes.

Overview
Adds a new i18n message key, pushNotificationCardKycNotificationCtaText, to the card KYC push-notification translations across supported locales (including en/en_GB and multiple non-English languages).

Also cleans up locales/en/messages.json formatting by removing stray diff artifacts and ensuring proper JSON termination.

Written by Cursor Bugbot for commit c9678d9. This will update automatically on new commits. Configure here.

@Brunonascdev Brunonascdev requested review from klejeune and oilnam March 3, 2026 13:06
@Brunonascdev Brunonascdev self-assigned this Mar 3, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

"message": "Lihat keputusan permohonan Anda."
},
"pushNotificationCardKycNotificationCtaText": {
"message": "Atur Karu MetaMask Anda"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indonesian translation typo: "Karu" instead of "Kartu"

Medium Severity

The Indonesian translation for pushNotificationCardKycNotificationCtaText has a typo — "Karu" instead of "Kartu" (Indonesian for "Card"). Other keys in the same file (e.g., pushNotificationCardKycCompletedDescription and pushNotificationCardKycFailedTitle) correctly use "Kartu". This will display an incorrect/misspelled word to Indonesian-speaking users.

Fix in Cursor Fix in Web

"message": "Xem quyết định về đơn đăng ký của bạn."
},
"pushNotificationCardKycNotificationCtaText": {
"message": "Thiết lập Thẻ MetaMask của bạn."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vietnamese CTA text has inconsistent trailing period

Low Severity

The Vietnamese pushNotificationCardKycNotificationCtaText message ends with a period ("Thiết lập Thẻ MetaMask của bạn.") while all other 15 locales omit it. Since the key name indicates this is CTA button text (CtaText), a trailing period is atypical for buttons and inconsistent with every other translation of this string.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant