Skip to content

Use environment variable for BASE_URL in pricesV2UsdAdapter #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blurpesec wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use environment variable for BASE_URL in pricesV2UsdAdapter #489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/adapters-library/src/adapters/prices-v2/products/usd/pricesV2UsdAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { ChainLink__factory, OneInchOracle__factory } from '../../contracts'
import { fiatDecimals, priceAdapterConfig } from './priceV2Config'

export const USD = 'USD'
const BASE_URL = 'https://price-api.metafi.codefi.network'
const BASE_URL = process.env.PRICE_API ?? 'https://price-api.metafi.codefi.network'
Copy link

@cursor cursor bot Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty env var bypasses fallback due to nullish coalescing

Medium Severity

Using ?? (nullish coalescing) instead of || means that if PRICE_API is set to an empty string (which some CI/Docker environments do), the fallback URL won't activate. An empty BASE_URL will then cause new URL(...) on line 112 to throw a TypeError: Invalid URL, and since that call sits outside the try/catch block, the error propagates unhandled from getSpotPriceByAddress.

Fix in Cursor Fix in Web


export interface SpotPrice {
allTimeHigh?: number
Expand Down
Loading