Roland's DeliverEat: Lovely Grubbly#6
Open
rolandjlevy wants to merge 35 commits intoconstructorlabs:masterfrom
Open
Roland's DeliverEat: Lovely Grubbly#6rolandjlevy wants to merge 35 commits intoconstructorlabs:masterfrom
rolandjlevy wants to merge 35 commits intoconstructorlabs:masterfrom
Conversation
Merge master and staging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will create Readme file shortly...
By the way, I struggled with the incQuantity function in MenuItem.js.
Originally I was incrementing the quantity of each item using state but when I wanted to reset the value to zero I got stuck because I couldn't use setState inside render. My workaround involves accessing the input element from the button element. The code looks kind of ridiculous:
const inputValue = Number(event.currentTarget.parentNode.parentNode.parentNode.parentNode.quantity.value)
Is there a better way of updating the input value from the button element?