Breakfast @ Tiffany's#20
Open
joelamb wants to merge 37 commits intoconstructorlabs:masterfrom
joelamb:master
Open
Breakfast @ Tiffany's#20joelamb wants to merge 37 commits intoconstructorlabs:masterfrom joelamb:master
joelamb wants to merge 37 commits intoconstructorlabs:masterfrom
joelamb:master
Conversation
| if (menuItems.length != 0) { | ||
| res.json(menuItems); | ||
| } else { | ||
| res.status(404).json({ error: 'Sorry, there are no items on the menu' }); |
| const ordersKeys = Object.keys(orders.customerOrders); | ||
| const id = ordersKeys.length > 0 ? Math.max(...ordersKeys) + 1 : 1; | ||
| orders.customerOrders = Object.assign({}, orders.customerOrders, { | ||
| [id]: order |
Contributor
There was a problem hiding this comment.
I would put the id property on the order itself, so you can know the id even when order object is outside of collection
Contributor
|
Great work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.