Skip to content

Conversation

@contagon
Copy link
Owner

@contagon contagon commented Nov 6, 2025

There was a handful of the API that had left over camelCase usage. Switch them all to snake_case.

@contagon contagon requested a review from Copilot November 6, 2025 19:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the codebase to standardize naming conventions by converting camelCase method names to snake_case format, improving consistency with Python naming conventions and making the API more idiomatic.

  • Renamed methods in SO3 and SE3 classes (e.g., fromMatfrom_mat, toMatto_mat, toEigento_eigen)
  • Updated string conversion methods (e.g., toStringto_string, toStringBriefto_string_brief)
  • Refactored C++ binding functions to use snake_case (e.g., makeTypesmake_types, makePipelinesmake_pipelines)

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/test_so3.py Updated test to use from_mat instead of fromMat
tests/test_se3.py Updated tests to use from_mat and to_mat instead of camelCase versions
python/evalio/datasets/multi_campus.py Updated SE3 instantiation to use from_mat
python/evalio/datasets/helipr.py Updated SO3 instantiation to use from_mat
python/evalio/datasets/cumulti.py Updated SE3 instantiation to use from_mat
python/evalio/datasets/botanic_garden.py Updated SE3 instantiation to use from_mat
cpp/evalio/types.h Renamed all camelCase methods to snake_case in Duration, Stamp, Point, LidarMeasurement, LidarParams, ImuMeasurement, ImuParams, SO3, and SE3 structs
cpp/evalio/convert/sophus.h Updated Sophus conversion to use to_eigen
cpp/bindings/types.h Updated Python bindings to use snake_case method names and renamed makeTypes to make_types
cpp/bindings/ros_pc2.h Renamed makeConversions to make_conversions
cpp/bindings/pipelines/loam.h Updated LOAM conversion to use from_eigen
cpp/bindings/pipelines/lio_sam.h Updated LIO-SAM to use to_eigen
cpp/bindings/pipelines/ct_icp.h Updated CT-ICP conversion to use from_mat
cpp/bindings/pipelines/bindings.h Renamed makePipelines to make_pipelines
cpp/bindings/pipeline.h Renamed makeBasePipeline to make_base_pipeline
cpp/bindings/main.cpp Updated all function calls to use new snake_case names

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@contagon contagon merged commit ded06a8 into main Nov 12, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants