feat(utils): implement symlink sandbox #1146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBasti
reviewed
Dec 10, 2024
osbs/utils/__init__.py
Outdated
| return self.uri | ||
|
|
||
|
|
||
| def _enforce_sandbox(repo_root: str, *, remove_unsafe_symlinks: bool) -> None: |
Contributor
There was a problem hiding this comment.
This shouldn't be a private method if we want to use it in atomic-reactor
What/why: implement detection/removal of unsafe symlinks in repos, specifically
covering cachi2 use case: Cachito already does this
How:
- copypasta `_enforce_sandbox()` and related unit tests from Cachito
("cachito/cachito/workers/tasks/general.py" and
"cachito/tests/test_workers/test_tasks/test_general.py", respectively)
- add call to `_enforce_sandbox()`
- add CLI boolean arg `remove-unsafe-symlinks`, which toggles removing all
symlinks which point to location(s) outside of any cloned repository
Signed-off-by: Ben Alkov <[email protected]>
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Ben Alkov <[email protected]>
MartinBasti
approved these changes
Dec 12, 2024
Member
Author
|
Moved implementation to atomic-reactor - it fits better there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainers will complete the following section
What/why: implement detection/removal of unsafe symlinks in repos, specifically
covering cachi2 use case: Cachito already does this
How:
_enforce_sandbox()and related unit tests from Cachito("cachito/cachito/workers/tasks/general.py" and
"cachito/tests/test_workers/test_tasks/test_general.py", respectively)
_enforce_sandbox()remove-unsafe-symlinks, which toggles removing allsymlinks which point to location(s) outside of any cloned repository