net: implement a backend for tap devices #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slp
requested review from
jakecorrenti,
MatiasVara,
mtjhrc and
tylerfanelli
as code owners
slp
force-pushed
the
net-tap
branch
7 times, most recently
from
c675d96 to
1c53e25
Compare
slp
force-pushed
the
net-tap
branch
3 times, most recently
from
0ebad2c to
4e51a43
Compare
mtjhrc
reviewed
Jul 25, 2025
mtjhrc
requested changes
Jul 25, 2025
slp
force-pushed
the
net-tap
branch
3 times, most recently
from
4e3b406 to
b5e6cf9
Compare
We're going to use it from different modules, so move them upper in the crate. Signed-off-by: Sergio Lopez <[email protected]>
We're going to incorporate a new backend that doesn't require us to write the header on each frame, so move this functionality from the worker to each backend. Signed-off-by: Sergio Lopez <[email protected]>
slp
force-pushed
the
net-tap
branch
2 times, most recently
from
0a09706 to
1ef4f3a
Compare
Implement a new backend that allows network interfaces to use a tap device on the host to read/write frames. Signed-off-by: Sergio Lopez <[email protected]>
With the new API, as we're actively participating in opening the connection to the network proxy, the creation of the virtio-net backend may fail. Avoid using "unwrap" and fail gracefully on device activation instead. Signed-off-by: Sergio Lopez <[email protected]>
We had cfg! checks for net on methods that are only present if net is enabled, so let's remove them. Suggested-by: Matej Hrica <[email protected]> Signed-off-by: Sergio Lopez <[email protected]>
|
@mtjhrc PTAL |
|
@mtjhrc do we need any more changes to this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a new backend that allows network interfaces to use a tap device on the host to read/write frames.