Add support for EDID display information #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtjhrc
force-pushed
the
display-edid
branch
6 times, most recently
from
3851d20 to
3ae01d8
Compare
Add support for the VIRTIO_GPU_CMD_GET_EDID command. An EDID blob can either be set by the user using krun_display_set_edid function or automatically generated by libkrun. Parameters to generate the edid can be set using the functions: - krun_display_set_dpi, - krun_display_set_physical_size - krun_display_set_refresh_rate Signed-off-by: Matej Hrica <[email protected]>
Add ability to specify display refresh rate and physical size, by extending the --display argument value. Signed-off-by: Matej Hrica <[email protected]>
mtjhrc
requested review from
jakecorrenti,
MatiasVara,
slp and
tylerfanelli
as code owners
slp
approved these changes
Aug 26, 2025
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for EDID (Extended Display Identification Data) for our
virtio-gpudevice and extend the public API in order to specify the more detailed display information.Clippy warnings are fixed in #386.