LWLP-925: integrate SPUR feedback (brand palette, column width) - #1221
LWLP-925: integrate SPUR feedback (brand palette, column width)#1221katarinazaprazna wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1221 +/- ##
=======================================
Coverage 63.89% 63.89%
=======================================
Files 149 149
Lines 5511 5511
Branches 1077 1077
=======================================
Hits 3521 3521
Misses 1688 1688
Partials 302 302
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
f2f0ea5 to
6ac1c35
Compare
|
just a thought, not sure if this was discussed somewhere 💭 |
|
Thanks for pointing this out @dominikvagner! It’s just dummy data for demonstration purposes at the moment. Before the ecosystem → language change happened, I’d often hear about upcoming support for the npm ecosystem, so I haven't questioned the naming. I’ll ask around, since technically it could be either JavaScript or TypeScript packages, and I’m not sure what we want to call it here |
| } | ||
| } | ||
|
|
||
| :where(.pf-v6-theme-dark) { |
There was a problem hiding this comment.
Quick note from our Slack discussion: this screenshot is actually from before dark mode color modulation was added
6ac1c35 to
cc24346
Compare
4eb350e to
b43dca6
Compare
b43dca6 to
de7c8b1
Compare
de7c8b1 to
197ed56
Compare
Avoids macOS gitignore matching Coverage/ so chart helpers are committed and CI can resolve them.
197ed56 to
02a0b7d
Compare
| @@ -90,7 +90,10 @@ const PackageCoverageTable = ({ uuid, ecosystems }: PackageCoverageTableProps) = | |||
| isError, | |||
There was a problem hiding this comment.
this looks so nice 🤩 awesome job!! just a couple thoughts:
- with the color switch in the charts, the label colors for "Exact" and "Partial" in the packages table might be confusing. what do you think about matching these label colors with the donut chart?
- the color shades for "exact"/"partial" inverting in dark mode could make "partial" look like the better match. as i understand it (and please correct me if this is wrong!), this is done this way because there might be concerns (accessibility, going against PF standards, etc) with keeping the "exact" shade more prominent in both light and dark modes?

Summary
Brand palette: Ecosystem exact/partial fills use CSS variables. Light mode keeps brand colors for exact matches and a white-mixed tint for partials. Dark mode lightens both so darker brand hexes stay above contrast ratio of 3:1. Unknown ecosystems fall back to purple tokens.
A11Y (ecosystem bars): The SVG chart is hidden from assistive tech and a screen-reader-only table exposes the same per-ecosystem counts. This companion-table approach was discussed in patternfly-react#2506.
Chart modularization: Charts move into standalone modules so a Lens report can be easily exported as PDF later. With explicit width/height, the charts serialize to SVG that Puppeteer can print (content-sources-frontend#1209). Charts can turn tooltips and legend on/off per surface (web or PDF).
Package table: Sets fixed column widths so the table layout and its loading skeleton stay the same.
Testing steps