Open
Conversation
tmathern
approved these changes
Feb 21, 2025
| } | ||
| } | ||
|
|
||
| /// Writes all the resources in a Reader to a folder. |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// Writes all the resources in a Reader to a folder. | |
| /// Writes all the resources from a Reader to a folder. |
Your non-native reviewer got confused by the wording, but maybe my grammer is off.
| /// Writes all the resources in a Reader to a folder. | ||
| /// | ||
| /// # Parameters | ||
| /// * reader_ptr: pointer to a Reader. |
Collaborator
There was a problem hiding this comment.
I like to add if the memory pointed to is actually modified or used read-only.
Here it's read-only, so not sure if it's worth adding?
| Ok(_) => 0, | ||
| Err(err) => { | ||
| Error::from_c2pa_error(err).set_last(); | ||
| -1 |
Collaborator
There was a problem hiding this comment.
Not saying we should, but we could return more precise error codes in the future (not for this PR).
| auto reader = c2pa::Reader("image/jpeg", dest); | ||
| auto json = reader.json(); | ||
| ASSERT_TRUE(json.find("c2pa.training-mining") != std::string::npos); | ||
| ASSERT_TRUE(json.find("cawg.training-mining") != std::string::npos); |
Collaborator
There was a problem hiding this comment.
Ack -
But our test cases could also have both during the transition period.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only works for file paths, there is currently no streaming equivalent.
Writes the manifest.json and all resource, under associated manifest label folders.