[DO NOT MERGE] Offline signing benchmark #1395
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1395 +/- ##
=======================================
Coverage 78.39% 78.39%
=======================================
Files 162 162
Lines 38776 38776
=======================================
+ Hits 30398 30400 +2
+ Misses 8378 8376 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reveals a significant performance gap which is written up in CAI-xxxx.
And also remove verify_after_sign. Much better results this way. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional tests for various offline signing scenarios.
Do not review; this is here as an archive and not intended for merging.