feat(sdk): Introduce new API for adding custom TSA callbacks #1568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Adding custom TSA callbacks to the Rust SDK through the CallbackSigner.
Trusted Signing Service (TSS) has implemented a custom C2PA signing and timestamping endpoint that they call their unified API. The unified API builds the correct countersignature structure and timestamps it, returning the signature of the data and its timestamp. When using this custom signer, we found that adding a Timestamp callback that fetches the cached timestamp value has significant performance improvements (~400 ms observed in testing) by avoiding the extra network round-trip.
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.