Skip to content

Conversation

@ok-nick
Copy link
Contributor

@ok-nick ok-nick commented Nov 19, 2025

Removes direct dependency on windows-core and updates chrono to 0.4.42 which previously depended on a yanked version of windows-core as described in #1116.

@ok-nick ok-nick added the check-release Add this label to any PR to invoke a larger suite of tests. label Nov 19, 2025
Copy link
Contributor

@tmathern tmathern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for running the check-release tests on this.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 19, 2025

CodSpeed Performance Report

Merging #1616 will not alter performance

Comparing ok-nick/remove-windows-core (220a38f) with main (de1feec)

Summary

✅ 16 untouched
⏩ 2 skipped1

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@ok-nick ok-nick merged commit 6fb348e into main Nov 21, 2025
120 checks passed
@ok-nick ok-nick deleted the ok-nick/remove-windows-core branch November 21, 2025 15:52
@caiopensrc caiopensrc mentioned this pull request Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

check-release Add this label to any PR to invoke a larger suite of tests. safe to test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants