Move timeout and progress reports to Simulation#1028
Open
pjonsson wants to merge 3 commits intocontiki-ng:masterfrom
Open
Move timeout and progress reports to Simulation#1028pjonsson wants to merge 3 commits intocontiki-ng:masterfrom
pjonsson wants to merge 3 commits intocontiki-ng:masterfrom
Conversation
c858c27 to
fb8d00a
Compare
Contributor
Author
|
@nfi Added the commit that migrates the progress report to this PR. It's the last set timeout that should get precedence. I'm not sure what decides the order. |
Member
|
I get an exception when I deactivate and then reactivate a simulation script: |
fb8d00a to
62e9c95
Compare
Contributor
Author
|
Fixed in latest update. |
Member
|
If you run a simulation until timeout, and then reload the simulation, the new simulation will immediately timeout without running anything. Also, it is no longer possible to continue running a simulation after first timeout. |
62e9c95 to
655fa22
Compare
Contributor
Author
|
Fixed. |
655fa22 to
8a8b235
Compare
Add a method that gets the time of the first scheduled item in the queue.
8a8b235 to
cd0e082
Compare
This moves the code for handling timeouts from LogScriptEngine to Simulation.
This removes the duplicate progress reports when using multiple script engines.
cd0e082 to
e806f49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the code for handling timeouts
and progress reports from LogScriptEngine to Simulation.