Closed
Conversation
Make the abort button in the progress dialog work. This is accomplished by loading simulation files in the background thread, but creating the simulation in the AWT thread, and then invokeLater to transfer the simulation back to the background thread. This is preparation for letting the user keep the current simulation when loading a new simulation fails.
nfi
approved these changes
Dec 23, 2022
pjonsson
force-pushed
the
gui-simplify-worker
branch
from
c38e21c to
bc64705
Compare
pjonsson
changed the title
Contributor
Author
|
@nfi Turned out the progress bar could be invoked in a different way, so this patch changed quite a lot to what you reviewed. |
Contributor
Author
|
This hangs the UI on OS X, which makes sense since Cooja does everything in the AWT thread. Will move the GUI elements into the GUI class instead, starting with #1041. |
Contributor
Author
|
The updated #918 solves this problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GUI: fix the abort button
Make the abort button in the progress dialog
work. This is accomplished by loading simulation
files in the background thread, but creating
the simulation in the AWT thread, and then
invokeLater to transfer the simulation back
to the background thread.
This is preparation for letting the user keep
the current simulation when loading a new simulation
fails.