feat: Support --diff3 flag in update command#2488
Draft
ytausch wants to merge 1 commit intocopier-org:masterfrom
Draft
feat: Support --diff3 flag in update command#2488ytausch wants to merge 1 commit intocopier-org:masterfrom
--diff3 flag in update command#2488ytausch wants to merge 1 commit intocopier-org:masterfrom
Conversation
…on with mergiraf
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2488 +/- ##
==========================================
+ Coverage 97.33% 97.34% +0.01%
==========================================
Files 55 55
Lines 6405 6432 +27
==========================================
+ Hits 6234 6261 +27
Misses 171 171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
Contributor
Author
|
Setting to draft because in the thread linked above, the core maintainer of git (Junio C Hamano) replied that they are willing to accept a patch that would enable the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
We want to use mergiraf with
copier updatein an automated copier update workflow. Mergiraf cannot be directly configured as a merge driver for our use case becausecopier updateusesgit merge-fileinternally. Hence, we rely on executing mergiraf in interactive mode aftercopier updatehas been run. We need diff3-style conflict markers for this.git merge-filecannot be globally configured to generate diff3-styled conflict markers; hencecopierneeds to pass the--diff3flag to it.I am aware of #2376, but this PR implements a quicker solution for immediate use with mergiraf.
Summary
--diff3flag to thecopier updatecommand that produces diff3-style conflict markers including the base version (from last update)AI Note
I generated this PR with assistance from Claude Code, but reviewed it manually.