Added ignore_terminal setting to allow bypassing the message "NVM For…#1071
Added ignore_terminal setting to allow bypassing the message "NVM For…#1071aaron777collins wants to merge 7 commits intocoreybutler:masterfrom
Conversation
… Windows should be run from a terminal such as CMD or Powershell." when you are using git bash (for people who want 1.1.11 behaviour).
|
This PR is stale because it has been open 45 days with no activity. |
Pulling in latest changes
… Windows should be run from a terminal such as CMD or Powershell." when you are using git bash (for people who want 1.1.11 behaviour).
…llins/nvm-windows into Allow_Ignore_Terminal
|
Please note that the most recent changes in this PR were meant for my own fork. They unintentionally made it in this PR afterwards. However, the original commit should work well as a fix. |
|
This PR is stale because it has been open 45 days with no activity. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
I've removed the artifacts from my forked repo (README changes) so that this can be merged :) |
|
Here's a link to a release I made a while ago if y'all want to see how the changes function. This is before I updated the fork to include the new 1.1.13 changes. Treat it as if it were 1.1.12. |
|
Should close #1068 if merged. Allows users to opt-in to checking the terminal (by setting the new property to false). |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Hey @VersoriumX - stop posting pointless comments. We don't use trigger keywords to merge anything. The plan is to revert the changes back to the original state. There was only one user who wanted this and it was for an easily avoidable situation that doesn't impact most people (i.e. clicking on the icon doe nothing... that was the point of terminal recognition). A new release is held up by the fact our SSL cert got locked. I'm working with the vendor to unlock it. |
|
This PR is stale because it has been open 45 days with no activity. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
This PR is stale because it has been open 45 days with no activity. |
|
This PR is stale because it has been open 45 days with no activity. |
3 participants
Closes #1068
Solves the issue "… Windows should be run from a terminal such as CMD or Powershell." when you are using git bash (for people who want 1.1.11 behaviour).