-
-
Notifications
You must be signed in to change notification settings - Fork 118
[WIP] Module level documentation pass #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
7df8e47
a28fa2d
f19c442
1e212f6
0af9e98
d1d1294
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,15 @@ | ||
| //! Wrappers around the [cublas API](https://docs.nvidia.com/cuda/cublas/index.html), | ||
| //! in three levels. See crate documentation for description of each. | ||
| //! [CudaBlas] wraps around the [cublas API](https://docs.nvidia.com/cuda/cublas/index.html). | ||
| //! | ||
| //! To use: | ||
| //! | ||
| //! 1. Instantiate a [CudaBlas] handle with [CudaBlas::new()] | ||
| //! 2. Choose your operation: [Gemm], [Gemv], and [Asum] traits, which [CudaBlas] implements. | ||
| //! 3. f16/bf16/f32/f64 are all supported at the trait level. | ||
| //! 4. Instantiate your corresponding config: [GemmConfig], [StridedBatchedConfig], [GemvConfig], [AsumConfig] | ||
| //! 5. Call using [CudaBlas::gemm()], [CudaBlas::gemv()], or [CudaBlas::asum()] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is slightly misleading. The methods like It would be clearer to show an example of a method call on an instance, e.g., //! 5. Call the trait's method on the handle, e.g. `blas.gemm(...)`.
|
||
| //! | ||
| //! Note that all above apis work with [crate::driver::DevicePtr]/[crate::driver::DevicePtrMut], so they | ||
| //! accept [crate::driver::CudaSlice], [crate::driver::CudaView], and [crate::driver::CudaViewMut]. | ||
|
|
||
| pub mod result; | ||
| pub mod safe; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This statement is incorrect. While the
Gemmtrait has implementations forf16,bf16,f32, andf64, theGemvandAsumtraits only supportf32andf64. This documentation is misleading to users of the library.Please update the documentation to accurately reflect the supported types for each trait.
//! 3. Supported types: [Gemm] supports `f16`/`bf16`/`f32`/`f64`; [Gemv] & [Asum] support `f32`/`f64`.